docs: add heroku deploy instructions #366
Conversation
docs/guide/deploy.md
Outdated
|
|
||
| # publish site | ||
| git push heroku master |
There was a problem hiding this comment.
Please move everything before this to something like 5. Set up your heroku git remote
Then put this line to 6. Deploying Your Site
Since only this line is needed to deploy the site, other lines just have to be done once.
There was a problem hiding this comment.
thanks for the review
patch configuration of heroku and deploy
| You can also deploy to a [custom domain](http://surge.sh/help/adding-a-custom-domain) by adding `surge docs/.vuepress/dist yourdomain.com`. |
There was a problem hiding this comment.
These two lines looks the same, I don't know why they are diffs？
There was a problem hiding this comment.
believe me I do not know either, just add a new line to start with the deploy in heroku
Any recommendation?
docs/guide/deploy.md
Outdated
| 5. Set up your heroku git remote | ||
|
|
||
| ``` bash |
There was a problem hiding this comment.
Keep the same indent here as above.
There was a problem hiding this comment.
I think he should remove the indentation from line 150 - 155
Do you mean how many users are using Heroku? |
Update indent between lines 150 - 155
| You can also deploy to a [custom domain](http://surge.sh/help/adding-a-custom-domain) by adding `surge docs/.vuepress/dist yourdomain.com`. |
There was a problem hiding this comment.
believe me I do not know either, just add a new line to start with the deploy in heroku
Any recommendation?
|
@ycmjason Yes, I want to know how many users are using Heroku? |
|
@ulivz heroku is very popular for deploying apps. So might be worthwhile to add this. |
No description provided.