Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($plugin-search): support non-latin characters (fix #2242) #2266

Closed
wants to merge 1 commit into from
Closed

fix($plugin-search): support non-latin characters (fix #2242) #2266

wants to merge 1 commit into from

Conversation

ThaddeusJiang
Copy link

@ThaddeusJiang ThaddeusJiang commented Apr 1, 2020

Summary

Fix #2242

Screenshot

  • Chinese

search

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome 80.0
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@meteorlxy
Copy link
Member

meteorlxy commented Apr 8, 2020

Closing due to #2283

@meteorlxy meteorlxy closed this Apr 8, 2020
@ThaddeusJiang ThaddeusJiang deleted the fix-2242 branch April 8, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change search plugin regular expression to support non-latin characters
2 participants