Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix core team links in section in README #2048

Merged
merged 3 commits into from
Dec 18, 2019
Merged

docs: fix core team links in section in README #2048

merged 3 commits into from
Dec 18, 2019

Conversation

ajitzero
Copy link
Contributor

Summary
Fixes #2047

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@ajitzero ajitzero changed the title Update README.md Fix #2047 - Updated links in core team section in README Nov 29, 2019
@ajitzero ajitzero changed the title Fix #2047 - Updated links in core team section in README fix: Updated links in core team section in README Nov 29, 2019
README.md Outdated Show resolved Hide resolved
@ajitzero
Copy link
Contributor Author

Fixed the links again, from /vue to /vuejs, but noticed a different sort of issue.

The users @filrak, @fatihacet and @farcaller don't have any commits in this repo. All these GitHub accounts exist, so I'm not sure what's happening.

@SigureMo
Copy link
Contributor

@ajitzero Sorry, I didn't read the README.md carefully, it seems auto generated by All Contributors(see README.md line58), so you change the .all-contributorsrc as well. 😄

@ajitzero
Copy link
Contributor Author

ajitzero commented Nov 29, 2019

@SigureMo I've updated the .all-contributorsrc file. The README.md changes will get overwritten with this. That should be it.

@kefranabg kefranabg changed the title fix: Updated links in core team section in README docs: fix core team links in section in README Dec 18, 2019
@kefranabg kefranabg merged commit bffd3a4 into vuejs:master Dec 18, 2019
@vue-bot
Copy link

vue-bot commented Dec 18, 2019

Hey @ajitzero, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@ajitzero ajitzero deleted the AjitZero-patch-2 branch December 18, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to commits by users still use older link in README.md
4 participants