Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor($theme-default): use stylus instead of native css in style tag #1933

Merged
merged 1 commit into from
Oct 11, 2019
Merged

refactor($theme-default): use stylus instead of native css in style tag #1933

merged 1 commit into from
Oct 11, 2019

Conversation

yoshinorin
Copy link
Contributor

@yoshinorin yoshinorin commented Oct 9, 2019

Summary

Use stylus instead of native css in style tag of default-theme.

A few of default-theme components <style> tag are mixed by native CSS and stylus. IMHO should use the same style.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@ulivz ulivz merged commit 7c973ab into vuejs:master Oct 11, 2019
@vue-bot
Copy link

vue-bot commented Oct 11, 2019

Hey @yoshinorin, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@yoshinorin yoshinorin deleted the css-to-stylus branch October 12, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants