feat: add async load of config #1618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank's for your work @romulocintra ! I know it's been a while since you create the pr. I will have to check a bit about async stuff here. It's look good anyway. |
flozero
added
status: awaiting more context
flozero
reviewed
Sep 7, 2019
| @@ -28,9 +28,12 @@ module.exports = function loadConfig (vuepressDir, bustCache = true) { | |||
| } else if (fs.existsSync(configTomlPath)) { | |||
| siteConfig = parseConfig(configTomlPath) | |||
| } else if (fs.existsSync(configPath)) { | |||
| siteConfig = require(configPath) | |||
| if (typeof require(configPath).then === 'function') { | |||
| siteConfig = require(configPath).then((config) => config) | |||
There was a problem hiding this comment.
if you can add a catch with a pretty error message it will be good for me.
use logs in shared utils package to log the error
There was a problem hiding this comment.
Hi @f3ltron not to much time to review and add a proper commit but updated with catch and logger.error message
flozero
added
need feedback
|
tank's for your work ! 👍 i validate it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #1185
Needs more convenient tests