Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor($theme-default): toc #1436

Merged
merged 8 commits into from
May 12, 2019
Merged

refactor($theme-default): toc #1436

merged 8 commits into from
May 12, 2019

Conversation

shigma
Copy link
Collaborator

@shigma shigma commented Mar 13, 2019

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

@shigma shigma self-assigned this Mar 13, 2019
Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I recommend that we separate the TOC plugin from the repo of vuepress, which is not our focus but will increase our additional maintenance costs.

@shigma shigma changed the title feat: toc plugin (close #1399) feat: toc plugin (close #1399, #1450) Mar 15, 2019
@shigma
Copy link
Collaborator Author

shigma commented Mar 15, 2019

Actually, I recommend that we separate the TOC plugin from the repo of vuepress, which is not our focus but will increase our additional maintenance costs.

I know, but some works need to be done to the VuePress core before TOC plugin can handle some issues.

@shigma shigma changed the title feat: toc plugin (close #1399, #1450) refactor($theme-default): toc Apr 7, 2019
@shigma shigma marked this pull request as ready for review April 7, 2019 15:08
@ulivz ulivz merged commit cab5b83 into master May 12, 2019
@vue-bot
Copy link

vue-bot commented May 12, 2019

Hey @shigma, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

ulivz added a commit that referenced this pull request May 12, 2019
@ulivz
Copy link
Member

ulivz commented May 12, 2019

@shigma Reverted this commit since it caused another issue of rendering incorrect TOC:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants