feat: Refine Node API & Improve test [WIP] #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- feat: Add getFragment、context、usePlugin - fix: cannot debug test cases at a child process
|
@shigma Feel free to continue to improve tests into this branch, meanwhile, we need to do following things:
|
ulivz
commented
Mar 3, 2019
| <div class="highlighted"> </div> | ||
| <br> | ||
| </div>export default function () { // .. } | ||
| </div> | ||
| `; |
There was a problem hiding this comment.
@shigma Note that this snap shouldn't be removed, I guess this case need to be updated.
ulivz
added
topic: config
ulivz
commented
Mar 4, 2019
| console.log(`running node with args: ${args.join(' ')}`) | ||
| await execa('node', args, { | ||
| await execa('jest', args, { |
There was a problem hiding this comment.
The jest runner is running under a child process, this change will cause the fail of debug since --inspect-brk is a node-level flag.
To make debug work, we need ensure that Parent and child process won't share the same inspecting port;
There was a problem hiding this comment.
We can merge this feature request first, and I believe this is not the real reason why Windows can't run test. Looking forward to your PR later. 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
yarn testsince it's running as a child process.What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: