Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LRU does not use the "new" operator #1160

Merged
merged 2 commits into from
Jan 8, 2019
Merged

fix: LRU does not use the "new" operator #1160

merged 2 commits into from
Jan 8, 2019

Conversation

bailnl
Copy link
Contributor

@bailnl bailnl commented Jan 4, 2019

Summary
Why does an LRU Class not use the new operator? Caused an error Uncaught TypeError: Class constructor LRU cannot be invoked without 'new'

i use npm install, the lru-cache is 5.x. but vuepress dep is 4.x

I found out why lru-cache became 5.x.
The reason is because @vue/cli-shared-utils uses ^5.1.1

Source location: https://github.com/isaacs/node-lru-cache/blob/master/index.js#L27

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use yarn then this issue will not exist. of course, it makes sense to upgrade it.

@ulivz ulivz merged commit 45481b9 into vuejs:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants