Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero Image Fails to Resize #849

Closed
rwxrob opened this issue Sep 17, 2018 · 3 comments
Closed

Hero Image Fails to Resize #849

rwxrob opened this issue Sep 17, 2018 · 3 comments
Labels
contribution welcome Contributions welcome

Comments

@rwxrob
Copy link

rwxrob commented Sep 17, 2018

Bug report

Nothing a max-width: 100% won't fix:

.hero img {
  max-width: 100%;
}

Before:
screen shot 2018-09-17 at 3 15 33 pm
After:
screen shot 2018-09-17 at 3 15 59 pm

Version

0.14.2

Steps to reproduce

Just create any image the is relatively wide and set as hero image.

What is expected?

Responsive resizing.

What is actually happening?

Not resizing.

Other relevant information

That should be enough. Can provide more if needed.

Thank you.

@ulivz
Copy link
Member

ulivz commented Sep 20, 2018

Welcome to create a PR for that, thanks!

@ulivz ulivz added the contribution welcome Contributions welcome label Sep 20, 2018
halaaro pushed a commit to halaaro/vuepress that referenced this issue Sep 21, 2018
@dsseng
Copy link
Contributor

dsseng commented Mar 2, 2019

Looks like it's already been fixed: https://github.com/vuejs/vuepress/blob/master/packages/%40vuepress/theme-default/components/Home.vue#L82

@deraw
Copy link
Contributor

deraw commented Mar 2, 2019

Yes, fixed by #980 🙂

@ulivz ulivz closed this as completed Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Contributions welcome
Projects
None yet
Development

No branches or pull requests

4 participants