Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default theme's smooth scrolling feature not working #1930

Closed
1 task done
wallslide opened this issue Oct 9, 2019 · 6 comments · Fixed by #1939
Closed
1 task done

Default theme's smooth scrolling feature not working #1930

wallslide opened this issue Oct 9, 2019 · 6 comments · Fixed by #1939

Comments

@wallslide
Copy link

  • I confirm that this is an issue rather than a question.

Bug report

Steps to reproduce

Here is the link to the repository with the issue --> https://github.com/appsocially/upil-site
The corresponding vuepress site is at https://upil.org/

I added the smoothScroll option to config.js here as is detailed in the docs.

What is expected?

Clicking links on the sidebar that point to the current page should smoothly scroll the page to that section.

What is actually happening?

The page jumps to intra-page anchors instead of smoothly scrolling to them.

Other relevant information

  • Output of npx vuepress info in my VuePress project:
System:
    OS: macOS 10.14.6
    CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
  Binaries:
    Node: 10.16.3 - ~/.nvm/versions/node/v10.16.3/bin/node
    Yarn: 1.13.0 - /usr/local/bin/yarn
    npm: 6.9.0 - ~/.nvm/versions/node/v10.16.3/bin/npm
  Browsers:
    Chrome: 77.0.3865.90
    Firefox: Not Found
    Safari: 13.0.2
  npmPackages:
    @vuepress/core:  1.1.0 
    @vuepress/theme-default:  1.1.0 
    vuepress: ^1.1.0 => 1.1.0 
  npmGlobalPackages:
    vuepress: Not Found
@kefranabg
Copy link
Collaborator

Hi @wallslide,

Actually smoothScroll feature was not released yet... It will be available in the next version of VuePress.

Our doc is always in bit ahead of releases 😅We need to fix this.

@Mister-Hope
Copy link
Contributor

Mister-Hope commented Oct 9, 2019

HHH I found this question ,too.

Maybe you can release a website called beta-vuepress.vuejs.com and merge your ahead Doc changes when new version released?

@kefranabg
Copy link
Collaborator

@Mister-Hope I described something that might be the solution here

@wallslide
Copy link
Author

When I searched for related issues first, I found this one #567 and saw that it resulted in a merged pr, so I got thrown off by that :)

@ulivz
Copy link
Member

ulivz commented Oct 11, 2019

@kefranabg We can let each new feature have a compatibility badge, e.g.

  • input:
# Content <Badge text="1.0.0+" />
  • output:

image

Maybe it should be listed in the contribution guide and pull request template.

// cc @f3ltron @bencodezen @meteorlxy

@kefranabg
Copy link
Collaborator

@ulivz I think using badge is a good idea to solve this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants