Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #976: fix height of input in SearchBox #1093

Merged
merged 1 commit into from
Dec 12, 2018
Merged

fix #976: fix height of input in SearchBox #1093

merged 1 commit into from
Dec 12, 2018

Conversation

deraw
Copy link
Contributor

@deraw deraw commented Dec 11, 2018

Summary

Link to issue: #976

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Doesn't include a ployfill for Aloglia Search, following https://github.com/algolia/instantsearch.js#browser-support.

@deraw deraw changed the title fix #976[https://github.com/vuejs/vuepress/issues/976]: fix height of input in SearchBox fix (#976)[https://github.com/vuejs/vuepress/issues/976]: fix height of input in SearchBox Dec 11, 2018
@deraw deraw changed the title fix (#976)[https://github.com/vuejs/vuepress/issues/976]: fix height of input in SearchBox fix #976: fix height of input in SearchBox Dec 11, 2018
Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ulivz ulivz merged commit 04510e9 into vuejs:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants