Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how could I fix navigation issue in IE11? #976

Closed
meision opened this issue Nov 4, 2018 · 6 comments
Closed

how could I fix navigation issue in IE11? #976

meision opened this issue Nov 4, 2018 · 6 comments
Labels
contribution welcome Contributions welcome

Comments

@meision
Copy link

meision commented Nov 4, 2018

As I notice that, when I use IE11 to browse https://vuepress.vuejs.org/, the search bar becomes narrow and search feature unavailable, as well as navigation item shift out right side of the screen.

Any idea to fix them, thank you in advanced.

@ulivz
Copy link
Member

ulivz commented Nov 6, 2018

I don't have a windows device, could you help to take a look at it and create a PR?

@ulivz ulivz added the contribution welcome Contributions welcome label Nov 6, 2018
@meision
Copy link
Author

meision commented Nov 10, 2018

Indeed? Tell me your address, and i will mail one to you. 😃

Please refer to follow pictures:

  1. Difference between chrome and IE.
  2. Search feature works fine in Chrome,
  3. Search feature not work in Chrome,

1
2
3

@teucer
Copy link

teucer commented Nov 22, 2018

Facing the same issue, any fix?

@deraw
Copy link
Contributor

deraw commented Dec 8, 2018

Hi!
I've noticed that there is the max-width: nullpx inline style applied on .navbar .links (in IE 11), but this doesn't actually affect the issue.

What causes the navigation links to hide on the right is a bug in IE with flex: 1.
To fix it, replace flex: 1; on .navbar .links .nav-links with flex: 1 0 auto;, or just remove it!

After that, the search icon is still not well-positionned, it seems that the best way to fix it is to set a fixed height on the input : height: 2rem; on .search-box input.

This fixed the interface, but if you're using Algolia search it's not over!
You'll need to add a polyfill in order to make it work, see https://hopingocean.github.io/vue-press/

If you wonder why https://vuepress.vuejs.org/ works well for this in IE 11, it's because they don't have flex: 1; on the navbar links, and that they're setting the heigt to 2rem on the input (with a media query to only apply on IE).

Going to do a PR to apply these fixes!

Also @ulivz, you can have a free BrowsterStack license for 5 users for any open-source project, so you can test an the majority of browsers! see browserstack.com/open-source

@deraw
Copy link
Contributor

deraw commented Dec 11, 2018

The first part of the issue has been fixed in 6734a60#diff-1f4a239c74ed05ddc03b5c94092deccc!

@deraw
Copy link
Contributor

deraw commented Dec 12, 2018

@ulivz I think you can close the issue now! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Contributions welcome
Projects
None yet
Development

No branches or pull requests

4 participants