fix($theme-default): slots don't allow customization for Sidebar & Pa…

…ge (close: #1950) (#1951)
vuejs · Oct 21, 2019 · 890e85d · 890e85d
1 parent d2fef5d
commit 890e85d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 18 deletions.
diff --git a/packages/@vuepress/theme-default/layouts/Layout.vue b/packages/@vuepress/theme-default/layouts/Layout.vue
@@ -19,14 +19,12 @@
       :items="sidebarItems"
       @toggle-sidebar="toggleSidebar"
     >
-      <slot
-        name="sidebar-top"
-        #top
-      />
-      <slot
-        name="sidebar-bottom"
-        #bottom
-      />
+      <template #top>
+        <slot name="sidebar-top" />
+      </template>
+      <template #bottom>
+        <slot name="sidebar-bottom"/>
+      </template>
     </Sidebar>
 
     <Home v-if="$page.frontmatter.home"/>
@@ -35,14 +33,12 @@
       v-else
       :sidebar-items="sidebarItems"
     >
-      <slot
-        name="page-top"
-        #top
-      />
-      <slot
-        name="page-bottom"
-        #bottom
-      />
+      <template #top>
+        <slot name="page-top"/>
+      </template>
+      <template #bottom>
+        <slot name="page-bottom"/>
+      </template>
     </Page>
   </div>
 </template>

diff --git a/packages/@vuepress/theme-vue/layouts/Layout.vue b/packages/@vuepress/theme-vue/layouts/Layout.vue
@@ -1,7 +1,11 @@
 <template>
   <ParentLayout>
-    <CarbonAds #sidebar-top/>
-    <BuySellAds #page-bottom/>
+    <template #sidebar-top>
+      <CarbonAds/>
+    </template>
+    <template #page-bottom>
+      <BuySellAds/>
+    </template>
   </ParentLayout>
 </template>