address comments

vuejs · Apr 14, 2018 · 50689ea · 50689ea
1 parent dbb7a08
commit 50689ea
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/docs/default-theme-config/README.md b/docs/default-theme-config/README.md
@@ -48,7 +48,7 @@ module.exports = {
 }
 ```
 
-The item in `themeConfig.nav` could also be a dropdown menu:
+Those links can also be dropdown menus, add nested items via `items`:
 
 ```js
 module.exports = {

diff --git a/lib/default-theme/NavLinks.vue b/lib/default-theme/NavLinks.vue
@@ -44,7 +44,7 @@ export default {
       return (this.$site.themeConfig.nav || []).map(({ text, link, type, items }) => ({
         text,
         type,
-        link: link ? ensureExt(link) : void 0,
+        link: link ? ensureExt(link) : null,
         items: (items || []).map(({ text, link }) => ({ text, link: ensureExt(link) }))
       }))
     },
@@ -98,26 +98,26 @@ export default {
         li
           color inherit
           line-height 1.7rem
-          padding: 0 1.5rem 0 1.25rem
+          padding 0 1.5rem 0 1.25rem
           a
             position relative
-            border-bottom: none
+            border-bottom none
             font-weight 400
+            &:hover
+              margin-bottom 0
+              color $accentColor
             &.router-link-active
-              color: $accentColor
-              &:after
-                content: ""
-                width: 0
-                height: 0
+              color $accentColor
+              &::after
+                content ""
+                width 0
+                height 0
                 border-left 5px solid $accentColor
                 border-top 4px solid transparent
                 border-bottom 4px solid transparent
                 position absolute
                 top calc(50% - 3px)
                 left -10px
-            &:hover
-              margin-bottom 0
-              color $accentColor
   .github-link
     margin-left 1.5rem
-Original file line number
+Diff line change
@@ Expand Up / @@ -48,7 +48,7 @@ module.exports = { @@
     }
     ```
-    The item in `themeConfig.nav` could also be a dropdown menu:
+    Those links can also be dropdown menus, add nested items via `items`:
     ```js
     module.exports = {
@@ Expand Down @@