Skip to content
This repository has been archived by the owner on Dec 26, 2018. It is now read-only.

Babel 7.0 Support #239

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Babel 7.0 Support #239

wants to merge 3 commits into from

Conversation

ullmark
Copy link

@ullmark ullmark commented Sep 18, 2018

This pull requests adds support for Babel 7.0. What I did was

  1. Ran npx babel-uppgrade --write
  2. Replaced mentions of babel-core and others with @babel/core
  3. Replaced env babel-preset-es2015 with @babel/preset-env as suggested in v7 upgrade manual

All tests run, and I've also tried installing the fork in a super simple test project using the following configs

.browserlistrc

Last 2 versions

.babelrc

{
  "presets": ["@babel/preset-env"]
}

Running browserify -t vueify -e src/main.js -o build/build.js produced a working output.

The @babel/runtime package had changed a bit, and couldn't require it similarly to the old codebase, but I found that it wasn't needed.

Have a look!

@Zae Zae mentioned this pull request Sep 28, 2018
@elliottregan
Copy link

Is this Repo dead?

@elliottregan
Copy link

elliottregan commented Oct 13, 2018

I get the error Cannot find module '@babel/runtime/helpers/interopRequireDefault'. Looks like it does need @babel/runtime. Manually installing @babel/runtime allows it to work, though.

@ullmark
Copy link
Author

ullmark commented Oct 13, 2018

@elliottregan strange that you needed to manually install @babel/runtime since it is a dependency in package.json...

I've tried using the fork in a project and got no issues. I can try again to make sure no updates in other packages are causing an issue.

re. this repo being dead; I doubt it. But yeah, would be nice to get Babel 7 support in. 😄

@ullmark
Copy link
Author

ullmark commented Oct 21, 2018

@elliottregan I've updated my test project with the latest dependencies, and also threw babelify into the mix but my (simple) project works fine without seeing that issue.

@LostCrew
Copy link

Great job @ullmark, too bad this repo looks like tumbleweeds rolling on the desert

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants