Skip to content
This repository has been archived by the owner on Dec 26, 2018. It is now read-only.

Insert attribute selector right before Pseudo-classes #21

Merged
merged 1 commit into from
Oct 30, 2015
Merged

Insert attribute selector right before Pseudo-classes #21

merged 1 commit into from
Oct 30, 2015

Conversation

hanachin
Copy link
Contributor

Currently, vueify compiles scoped css like:

<style scoped>
.foo:after {
  content: 'bar';
}
</style>

to

.foo:after[{{id}}] {
  content: 'bar';
}

So that never applied because .after[{{id}}] doesn't have {{id}} attribute.
{{id}} should insert before pseudo-classes.

yyx990803 added a commit that referenced this pull request Oct 30, 2015
Insert attribute selector right before Pseudo-classes
@yyx990803 yyx990803 merged commit b6e4e25 into vuejs:master Oct 30, 2015
@hanachin hanachin deleted the insert-before-pseudo branch October 30, 2015 15:30
@yyx990803
Copy link
Member

Good catch! 👍

@hanachin
Copy link
Contributor Author

Thank you 😃 Scoped CSS is great <3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants