-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(model): add .eager modifier to v-model #9814
base: dev
Are you sure you want to change the base?
Conversation
Ignore `composing` value on the input and eagerly modify the value while the user is still composing a value. vuejs#9299 vuejs#9777
Do you have a forecast of when it will be released? Thanks |
Thanks for the PR, @posva! I hope that feature be approved soon. @nolimitdev, I hope you read this PR. I think there's no better solution than that. Thank you for contribuition in #8231! |
@lvfxbr One thing I do not understand... how it is possible that in old VUE 1 v-model works well out of the box on android device during auto prediction... I mentioned it in #8231 in 2018y but got no reaction and today most favourite comment in #8231 was incomprehensibly removed by maintainer. I noticed this bug a long time ago during migration from VUE 1 to VUE 2. Please test someone it in old VUE 1 and confirm that it works or not. So v-model can technically work on VUE 1 but can not on VUE 2 and VUE 3? Maybe Im missing something I did not read source code what is the difference. |
@nolimitdev, I did a test in latest update of Vue 1 (1.0.28) from 2016. I created a repository to test this here, I tested in my smartphone and really, the v-model works fine: This is the branches I created for compare the vue versions: This is the live tests, everyone can test it in mobile: We can investigate what changed Vue 1 to Vue 2. |
Hey guys, i've been wondering if this .eager feature is gonna come out? thank you
the .eager would be better but i hope it helps while it's not released |
For those who are still waiting for the fix and don't want to replace <input v-model="myModel" @input="$event.target.composing = false"> |
@posva did you please noticed @lvfxbr 's comment #9814 (comment) ? Thanks. It seems that no .eager is needed just to investigate how it is possible that VUE v1 did not have this bug but v2 and v3 has. |
Will this be fixed in Vue 2 or 3? Anything we can do to help this get merged? |
This worked for me using Nuxt 2.15! |
Worked like a charm |
@yyx990803 would it be possible for this PR to make it into 2.7? |
It would appear that Either the documentation is wrong or the functionality is wrong. However it seems all these issues are being pushed into the "It's all your fault stupid user" basket instead of the problem being solved. Complete with reports of this issue being prematurely closed. Meanwhile potential solutions are left to go stale. This issue could be better handled. It is not working as intended and reports of such are continually being obstructed |
Add an
.eager
modifier to v-model that ignorecomposing
value on the input and eagerly modify the value while the user is still composing a value. #9299 #9777.See the rationale behind this at #9777 (comment)
Since the default keyboard on Android, GBoard, does composing by default, I think it makes sense to have a modifier to disable the composing behaviour while still benefitting from using v-model.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: