Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9577): support deep object as dynamic arguments #9585

Merged
merged 4 commits into from
Feb 28, 2019
Merged

fix(#9577): support deep object as dynamic arguments #9585

merged 4 commits into from
Feb 28, 2019

Conversation

shasharoman
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Fixed issue #9577.

The old modifier matching pattern is /\.[^.]+/g, It does not take into account that dynamic arguments may contain .,so I updated it and hope it is correct.

code example:

const before = /\.[^.]+/g;
const after = /\.[^.\]]+(?=\.|$)/g;

let s = 'name:[a.b].c.d';

console.log(s.match(before)); // [".b]", ".c", ".d"]
console.log(s.match(after));    // [".c", ".d"]

src/compiler/parser/index.js Outdated Show resolved Hide resolved
test/unit/features/options/directives.spec.js Show resolved Hide resolved
src/compiler/parser/index.js Outdated Show resolved Hide resolved
test/unit/features/options/directives.spec.js Show resolved Hide resolved
@yyx990803
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants