-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v-model
did not handle CompositionEvent on Android
#7367
v-model
did not handle CompositionEvent on Android
#7367
Comments
Giving pull request according to my suggestion: #7368 |
Thanks, it sounds reasonable. Any suggestion? @ktsn @kazupon ? OP suggests that v-model should only update value after The Android check dates back long ago. It looks like we just leave it untouched in the code base. Yup, Chinese input just stop firing input event during composing. Japanese Input correctly fires input and correctly set event.isComposing to true. However, Vue uses https://jsfiddle.net/ov5jqqss/ BTW, a very whitey test case that almost valuable to be collected in an album, hehe. |
v-model
did not handle CompositionEvent on Android
Translate to English for more extensive discussion. |
Hi there, I am actually developing an application (in Nuxt.js) where I need the exact behaviour you reported. My application has not the expected behaviour on Android. I need the v-model binding to behave when composing on Android keyboard. On Iphone, everything is working. How can we fix that? Thank you :) |
Previously the installation was skipped on Android because it was not needed for Chinese IME - however some IMEs such as Japanese exhibits the same behavior as on other browers. So it is safer to always enable the check. Closes vuejs#7367
Previously the installation was skipped on Android because it was not needed for Chinese IME - however some IMEs such as Japanese exhibits the same behavior as on other browers. So it is safer to always enable the check. Closes vuejs#7367
Version
2.5.13
Reproduction link
https://codepen.io/LeuisKen/pen/ZvydmK?editors=1010
Steps to reproduce
1、Chrome 63 on Android, select the input tag;
2、Use IME, such as Google Japanese in example;
3、Inputing contents.
What is expected?
Update data only when compositionend event fired, according to issue:
#5158 (comment)
What is actually happening?
See the screen shot in
Steps to reproduce
, v-model sync the input data when compositionend not fired.Suggestion: Replacing
isAndroid
check in code https://github.com/vuejs/vue/blob/dev/src/platforms/web/runtime/directives/model.js#L42 withwindow.CompositionEvent
.The text was updated successfully, but these errors were encountered: