Template querySelector support #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earnubs
changed the title
|
A few notes:
|
|
This is a great addition! Nice job. As pointed out, try something like Your suspicion about mutating window/document were correct @dobromir-hristov. For this reason, before and after each test, the window variable is reset, to keep things clean. See here. I'm happy to approve this once
Are you able to make these changes, @earnubs ? |
lmiller1990
requested changes
Dec 16, 2019
test/specs/mount.spec.js
Outdated
| @@ -161,6 +161,26 @@ describeRunIf(process.env.TEST_ENV !== 'node', 'mount', () => { | |||
| expect(wrapper.html()).to.equal(`<div>foo</div>`) | |||
| }) | |||
|
|
|||
| it('compiles templates from querySelector', () => { | |||
| if ( | |||
| !(navigator.userAgent.includes && navigator.userAgent.includes('node.js')) | |||
earnubs
force-pushed
the
template-query-selector-support
branch
from
8a4c379 to
e1c1b95
Compare
|
Test is failing, I'll take a look at this tonight when I have a bit more time. |
lmiller1990
approved these changes
Dec 17, 2019
|
Hey @earnubs, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle selectors passed in the
templateoption of the Vue instance (https://vuejs.org/v2/api/#template), currently test-utils gives an unfriendly error as the selector is passed as a template string:Repro here: https://jsfiddle.net/earnubs/c5d2mea7/