Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hash): Properly handle encoded parameters in hash (close #2725) #3045

Closed
wants to merge 1 commit into from

Conversation

isra17
Copy link

@isra17 isra17 commented Nov 27, 2019

Fix an issue where page browsing to a route and then reloading leads to inconsistent parameters and fullPath values.

Fix an issue where page browsing to a route and then reloading leads to
inconsistent parameters and fullPath values.
@posva
Copy link
Member

posva commented May 11, 2020

hello, sorry for the delay. Do you have a reproduction for this one?

@isra17
Copy link
Author

isra17 commented May 11, 2020

It relates to #2725, specifically, when I click a link to #/%252520 my URL get transformed to #/%20 and when I reload the page I get #/ which is not correct and consistent. This fix might not be the proper fix, but we have been using this patch and didn't have issues so far.

@posva
Copy link
Member

posva commented May 12, 2020

@isra17 can you provide an actual repro (you can use this: https://jsfiddle.net/posva/9r6xhqbp/). Also what browsers are you seeing this at? Only hash mode?

@isra17
Copy link
Author

isra17 commented May 12, 2020

Can't repro injsfiddle due to URL not being visiable/modifiable. Both chrome and firefox at least. I didn't test on other mode than hash mode.

You can close the issue, I don't have my environnement with this bug anymore and I don't have the bandwith right now to dig further on this.

Cheers!

@posva
Copy link
Member

posva commented Jun 24, 2020

I revisited the problem and there are a few other issues. The actual problem of double decoding affects both history and hash mode. Thanks for the case of /%252520, it's a good one to check double encoding!

@posva posva closed this Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants