Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the error caused by the same path and alias of RouteConfig #2462

Closed
wants to merge 4 commits into from
Closed

Fix the error caused by the same path and alias of RouteConfig #2462

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34a4ef0
Fix the error caused by the same path and alias of RouteConfig
Nov 1, 2018
635135f
warning path with the same value as an alias
Nov 8, 2018
53e062f
fix flow check
Nov 8, 2018
05c90b6
path alias same warning in development
Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 29 additions & 21 deletions src/create-route-map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,32 +112,40 @@ function addRouteRecord (
})
}

if (route.alias !== undefined) {
const aliases = Array.isArray(route.alias)
? route.alias
: [route.alias]

aliases.forEach(alias => {
const aliasRoute = {
path: alias,
children: route.children
}
addRouteRecord(
pathList,
pathMap,
nameMap,
aliasRoute,
parent,
record.path || '/' // matchAs
)
})
}

if (!pathMap[record.path]) {
pathList.push(record.path)
pathMap[record.path] = record
}

if (route.alias !== undefined) {
if (route.alias === path) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warn should only appear on dev mode. Also could you add a test for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I have already added

warn(
false,
`Path with the same value as an alias: ` +
`{ path: "${path}" }`
)
} else {
const aliases = Array.isArray(route.alias)
? route.alias
: [route.alias]

aliases.forEach(alias => {
const aliasRoute = {
path: alias,
children: route.children
}
addRouteRecord(
pathList,
pathMap,
nameMap,
aliasRoute,
parent,
record.path || '/' // matchAs
)
})
}
}

if (name) {
if (!nameMap[name]) {
nameMap[name] = record
Expand Down