fix(compiler-sfc): removeSpecifier issue when removing initial imports (script-setup) #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2021
antfu
added
❗ p4-important
antfu
reviewed
Feb 9, 2021
| @@ -141,6 +141,17 @@ const myEmit = defineEmit(['foo', 'bar']) | |||
| ) | |||
| }) | |||
|
|
|||
| test('should allow defineProps/Emit at the start of imports', () => { | |||
There was a problem hiding this comment.
Maybe it's better to have a comment linking to the PR/issue here.
There was a problem hiding this comment.
Added a reference to #2740, following the convention that I saw in other tests (not the full link, just the number)
antfu
approved these changes
Feb 10, 2021
edison1105
approved these changes
Feb 10, 2021
LinusBorg
changed the title
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with
removeSpecifierincompilerScript.tswhen there are several initial imports removed.was being compiled to
Adds a test case in
compileScript.spec.ts