Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script setup sometimes generate invalid code when using defineEmit and defineProps #2740

Closed
leopiccionia opened this issue Dec 6, 2020 · 2 comments · Fixed by #2729
Closed

script setup sometimes generate invalid code when using defineEmit and defineProps #2740

leopiccionia opened this issue Dec 6, 2020 · 2 comments · Fixed by #2729
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. has workaround A workaround has been found to avoid the problem 🐞 bug Something isn't working scope: compiler

Comments

@leopiccionia
Copy link
Contributor

leopiccionia commented Dec 6, 2020 •
edited
Loading

Version

3.0.4

Reproduction link

https://github.com/leopiccionia/vue-script-setup-emit-repro

Steps to reproduce

Just run the repro, with npm run dev.

What is expected?

Compiler should generate valid code.

What is actually happening?

Code fails with syntax error.

The problem is in this line from output:

import { , ref } from '/@modules/vue.js'

The preceding comma is not valid in this place of import statement.

A workaround is changing the order of imports, so that defineEmit and defineProps are trailing.

I'm not sure if this is a Vite-specific error. I can move the issue, if needed.
@leopiccionia
Copy link
Contributor Author

leopiccionia commented Dec 6, 2020 •
edited
Loading

I think that PR #2729 should be a fix.

@posva posva linked a pull request Dec 7, 2020 that will close this issue
fix(compiler-sfc): removeSpecifier issue when removing initial imports (script-setup) #2729
Merged
@posva posva added 🐞 bug Something isn't working ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: compiler has workaround A workaround has been found to avoid the problem labels Dec 7, 2020
@CHOYSEN CHOYSEN mentioned this issue Dec 10, 2020
Closed
Wizard67 added a commit to Wizard67/comz that referenced this issue Jan 26, 2021
@Wizard67
fix: extract the import of 'defineProps' and 'defineEmit'
6046fda 
issues: vuejs/core#2740
@leopiccionia leopiccionia mentioned this issue Jan 27, 2021
Closed
@HcySunYang HcySunYang linked a pull request Jan 28, 2021 that will close this issue
fix(compiler-sfc): remove the defineProps/defineEmit specifiers correctly #3089
Closed
@HcySunYang
Copy link
Member

I did not notice that #3088 is a duplicate of this issue, and I submitted a fix there. So I also linked my PR here, because there are some differences between my PR and #2729

@CHOYSEN CHOYSEN mentioned this issue Jan 28, 2021
Closed
3 tasks
patak-dev added a commit to patak-dev/vue-next that referenced this issue Feb 9, 2021
@patak-dev
chore(compiler-sfc): vuejs#2740 github issue reference for test
7dd2458
@patak-dev patak-dev mentioned this issue Feb 9, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. has workaround A workaround has been found to avoid the problem 🐞 bug Something isn't working scope: compiler
Projects
None yet
Milestone
No milestone
3 participants
@posva @leopiccionia @HcySunYang