fix: fix template options resolving for ts

vuejs · Sep 22, 2021 · 91f581b · 91f581b
1 parent 1666885
commit 91f581b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/src/resolveScript.ts b/src/resolveScript.ts
@@ -66,9 +66,7 @@ export function resolveScript(
           compiler: templateCompiler,
           compilerOptions: {
             ...options.compilerOptions,
-            ...(options.enableTsInTemplate
-              ? resolveTemplateTSOptions(descriptor, options.compilerOptions)
-              : null),
+            ...resolveTemplateTSOptions(descriptor, options),
           },
           transformAssetUrls: options.transformAssetUrls || true,
         },

diff --git a/src/templateLoader.ts b/src/templateLoader.ts
@@ -63,9 +63,7 @@ const TemplateLoader: webpack.loader.Loader = function (source, inMap) {
       ...options.compilerOptions,
       scopeId: query.scoped ? `data-v-${scopeId}` : undefined,
       bindingMetadata: script ? script.bindings : undefined,
-      ...(options.enableTsInTemplate
-        ? resolveTemplateTSOptions(descriptor, options.compilerOptions)
-        : null),
+      ...resolveTemplateTSOptions(descriptor, options),
     },
     transformAssetUrls: options.transformAssetUrls || true,
   })

diff --git a/src/util.ts b/src/util.ts
@@ -1,12 +1,15 @@
 import { SFCDescriptor, CompilerOptions } from '@vue/compiler-sfc'
+import { VueLoaderOptions } from '.'
 
 export function resolveTemplateTSOptions(
   descriptor: SFCDescriptor,
-  options: CompilerOptions | null | undefined
-): CompilerOptions {
+  options: VueLoaderOptions
+): CompilerOptions | null {
+  if (options.enableTsInTemplate === false) return null
+
   const lang = descriptor.script?.lang || descriptor.scriptSetup?.lang
   const isTS = !!(lang && /tsx?$/.test(lang))
-  let expressionPlugins = (options && options.expressionPlugins) || []
+  let expressionPlugins = options?.compilerOptions?.expressionPlugins || []
   if (isTS && !expressionPlugins.includes('typescript')) {
     expressionPlugins = [...expressionPlugins, 'typescript']
   }