fix: shorthand camelize should be used in rawName
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
requested changes
Jan 20, 2024
waynzh
commented
Jan 21, 2024
ota-meshi
requested changes
Jan 22, 2024
| "type": "module", | ||
| "variables": [ | ||
| { | ||
| "name": "src", |
There was a problem hiding this comment.
Could you please run npm run update-fixtures?
renovate bot
referenced
this pull request
in woodpecker-ci/woodpecker
Jan 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@iconify/json](https://iconify.design/icon-sets/) ([source](https://togithub.com/iconify/icon-sets)) | [`2.2.171` -> `2.2.174`](https://renovatebot.com/diffs/npm/@iconify%2fjson/2.2.171/2.2.174) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | [`20.11.5` -> `20.11.6`](https://renovatebot.com/diffs/npm/@types%2fnode/20.11.5/20.11.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/typescript-eslint) ([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`6.19.0` -> `6.19.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/6.19.0/6.19.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/parser](https://togithub.com/typescript-eslint/typescript-eslint) ([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`6.19.0` -> `6.19.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/6.19.0/6.19.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vite-plugin-prismjs](https://togithub.com/code-farmer-i/vite-plugin-prismjs) | [`^0.0.8` -> `^0.0.11`](https://renovatebot.com/diffs/npm/vite-plugin-prismjs/0.0.8/0.0.11) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vue-eslint-parser](https://togithub.com/vuejs/vue-eslint-parser) | [`9.4.0` -> `9.4.2`](https://renovatebot.com/diffs/npm/vue-eslint-parser/9.4.0/9.4.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>iconify/icon-sets (@​iconify/json)</summary> ### [`v2.2.174`](https://togithub.com/iconify/icon-sets/compare/2.2.173...2.2.174) [Compare Source](https://togithub.com/iconify/icon-sets/compare/2.2.173...2.2.174) ### [`v2.2.173`](https://togithub.com/iconify/icon-sets/compare/2.2.172...2.2.173) [Compare Source](https://togithub.com/iconify/icon-sets/compare/2.2.172...2.2.173) ### [`v2.2.172`](https://togithub.com/iconify/icon-sets/compare/2.2.171...2.2.172) [Compare Source](https://togithub.com/iconify/icon-sets/compare/2.2.171...2.2.172) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v6.19.1`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#6191-2024-01-22) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.19.0...v6.19.1) ##### 🩹 Fixes - **type-utils:** preventing isUnsafeAssignment infinite recursive calls - **eslint-plugin:** \[no-unnecessary-condition] fix false positive for type variable ##### ❤️ Thank You - YeonJuan You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v6.19.1`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#6191-2024-01-22) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.19.0...v6.19.1) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>code-farmer-i/vite-plugin-prismjs (vite-plugin-prismjs)</summary> ### [`v0.0.11`](https://togithub.com/code-farmer-i/vite-plugin-prismjs/compare/5a78b11863afb5806d34096c72ba43209eccf405...8475fd891c7b1580318735e9614e28cbce766e19) [Compare Source](https://togithub.com/code-farmer-i/vite-plugin-prismjs/compare/5a78b11863afb5806d34096c72ba43209eccf405...8475fd891c7b1580318735e9614e28cbce766e19) ### [`v0.0.10`](https://togithub.com/code-farmer-i/vite-plugin-prismjs/compare/81ed9ec3d0e3f72b693f642741afb87ef6158ac2...5a78b11863afb5806d34096c72ba43209eccf405) [Compare Source](https://togithub.com/code-farmer-i/vite-plugin-prismjs/compare/81ed9ec3d0e3f72b693f642741afb87ef6158ac2...5a78b11863afb5806d34096c72ba43209eccf405) ### [`v0.0.9`](https://togithub.com/code-farmer-i/vite-plugin-prismjs/compare/1c1b7395e3c6b3f470f003ba271e1f772a4d3130...81ed9ec3d0e3f72b693f642741afb87ef6158ac2) [Compare Source](https://togithub.com/code-farmer-i/vite-plugin-prismjs/compare/1c1b7395e3c6b3f470f003ba271e1f772a4d3130...81ed9ec3d0e3f72b693f642741afb87ef6158ac2) </details> <details> <summary>vuejs/vue-eslint-parser (vue-eslint-parser)</summary> ### [`v9.4.2`](https://togithub.com/vuejs/vue-eslint-parser/releases/tag/v9.4.2) [Compare Source](https://togithub.com/vuejs/vue-eslint-parser/compare/v9.4.1...v9.4.2) ##### 🐛 Bug Fixes - Fix an error when using default for generic by [@​ota-meshi](https://togithub.com/ota-meshi) in [https://github.com/vuejs/vue-eslint-parser/pull/222](https://togithub.com/vuejs/vue-eslint-parser/pull/222) **Full Changelog**: vuejs/vue-eslint-parser@v9.4.1...v9.4.2 ### [`v9.4.1`](https://togithub.com/vuejs/vue-eslint-parser/releases/tag/v9.4.1) [Compare Source](https://togithub.com/vuejs/vue-eslint-parser/compare/v9.4.0...v9.4.1) ##### 🐛 Bug Fixes - fix: shorthand camelize should be used in `rawName` by [@​waynzh](https://togithub.com/waynzh) in [https://github.com/vuejs/vue-eslint-parser/pull/218](https://togithub.com/vuejs/vue-eslint-parser/pull/218) - Fix an error when using CRLF for generic directive by [@​ota-meshi](https://togithub.com/ota-meshi) in [https://github.com/vuejs/vue-eslint-parser/pull/220](https://togithub.com/vuejs/vue-eslint-parser/pull/220) **Full Changelog**: vuejs/vue-eslint-parser@v9.4.0...v9.4.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - "before 4am" (UTC). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/woodpecker-ci/woodpecker). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2 tasks
fernandrone
referenced
this pull request
in quintoandar/woodpecker
Feb 1, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@iconify/json](https://iconify.design/icon-sets/) ([source](https://togithub.com/iconify/icon-sets)) | [`2.2.171` -> `2.2.174`](https://renovatebot.com/diffs/npm/@iconify%2fjson/2.2.171/2.2.174) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | [`20.11.5` -> `20.11.6`](https://renovatebot.com/diffs/npm/@types%2fnode/20.11.5/20.11.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/typescript-eslint) ([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`6.19.0` -> `6.19.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/6.19.0/6.19.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/parser](https://togithub.com/typescript-eslint/typescript-eslint) ([source](https://togithub.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`6.19.0` -> `6.19.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/6.19.0/6.19.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vite-plugin-prismjs](https://togithub.com/code-farmer-i/vite-plugin-prismjs) | [`^0.0.8` -> `^0.0.11`](https://renovatebot.com/diffs/npm/vite-plugin-prismjs/0.0.8/0.0.11) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vue-eslint-parser](https://togithub.com/vuejs/vue-eslint-parser) | [`9.4.0` -> `9.4.2`](https://renovatebot.com/diffs/npm/vue-eslint-parser/9.4.0/9.4.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>iconify/icon-sets (@​iconify/json)</summary> ### [`v2.2.174`](https://togithub.com/iconify/icon-sets/compare/2.2.173...2.2.174) [Compare Source](https://togithub.com/iconify/icon-sets/compare/2.2.173...2.2.174) ### [`v2.2.173`](https://togithub.com/iconify/icon-sets/compare/2.2.172...2.2.173) [Compare Source](https://togithub.com/iconify/icon-sets/compare/2.2.172...2.2.173) ### [`v2.2.172`](https://togithub.com/iconify/icon-sets/compare/2.2.171...2.2.172) [Compare Source](https://togithub.com/iconify/icon-sets/compare/2.2.171...2.2.172) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v6.19.1`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#6191-2024-01-22) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.19.0...v6.19.1) ##### 🩹 Fixes - **type-utils:** preventing isUnsafeAssignment infinite recursive calls - **eslint-plugin:** \[no-unnecessary-condition] fix false positive for type variable ##### ❤️ Thank You - YeonJuan You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v6.19.1`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#6191-2024-01-22) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.19.0...v6.19.1) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>code-farmer-i/vite-plugin-prismjs (vite-plugin-prismjs)</summary> ### [`v0.0.11`](https://togithub.com/code-farmer-i/vite-plugin-prismjs/compare/5a78b11863afb5806d34096c72ba43209eccf405...8475fd891c7b1580318735e9614e28cbce766e19) [Compare Source](https://togithub.com/code-farmer-i/vite-plugin-prismjs/compare/5a78b11863afb5806d34096c72ba43209eccf405...8475fd891c7b1580318735e9614e28cbce766e19) ### [`v0.0.10`](https://togithub.com/code-farmer-i/vite-plugin-prismjs/compare/81ed9ec3d0e3f72b693f642741afb87ef6158ac2...5a78b11863afb5806d34096c72ba43209eccf405) [Compare Source](https://togithub.com/code-farmer-i/vite-plugin-prismjs/compare/81ed9ec3d0e3f72b693f642741afb87ef6158ac2...5a78b11863afb5806d34096c72ba43209eccf405) ### [`v0.0.9`](https://togithub.com/code-farmer-i/vite-plugin-prismjs/compare/1c1b7395e3c6b3f470f003ba271e1f772a4d3130...81ed9ec3d0e3f72b693f642741afb87ef6158ac2) [Compare Source](https://togithub.com/code-farmer-i/vite-plugin-prismjs/compare/1c1b7395e3c6b3f470f003ba271e1f772a4d3130...81ed9ec3d0e3f72b693f642741afb87ef6158ac2) </details> <details> <summary>vuejs/vue-eslint-parser (vue-eslint-parser)</summary> ### [`v9.4.2`](https://togithub.com/vuejs/vue-eslint-parser/releases/tag/v9.4.2) [Compare Source](https://togithub.com/vuejs/vue-eslint-parser/compare/v9.4.1...v9.4.2) ##### 🐛 Bug Fixes - Fix an error when using default for generic by [@​ota-meshi](https://togithub.com/ota-meshi) in [https://github.com/vuejs/vue-eslint-parser/pull/222](https://togithub.com/vuejs/vue-eslint-parser/pull/222) **Full Changelog**: vuejs/vue-eslint-parser@v9.4.1...v9.4.2 ### [`v9.4.1`](https://togithub.com/vuejs/vue-eslint-parser/releases/tag/v9.4.1) [Compare Source](https://togithub.com/vuejs/vue-eslint-parser/compare/v9.4.0...v9.4.1) ##### 🐛 Bug Fixes - fix: shorthand camelize should be used in `rawName` by [@​waynzh](https://togithub.com/waynzh) in [https://github.com/vuejs/vue-eslint-parser/pull/218](https://togithub.com/vuejs/vue-eslint-parser/pull/218) - Fix an error when using CRLF for generic directive by [@​ota-meshi](https://togithub.com/ota-meshi) in [https://github.com/vuejs/vue-eslint-parser/pull/220](https://togithub.com/vuejs/vue-eslint-parser/pull/220) **Full Changelog**: vuejs/vue-eslint-parser@v9.4.0...v9.4.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - "before 4am" (UTC). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/woodpecker-ci/woodpecker). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addressed the issue reported in vuejs/eslint-plugin-vue#2370.
I believe the issue is from
vue-eslint-parsertransforming thenameinto camel case. For example, thenamefor:fooBaris being interpreted asfoobar, which won't match with the variablefooBar.This PR proposes camelizing the
rawNameinstead, which should hopefully resolve the problem.I'll throw in some test cases soon if this fix makes sense.