fix(vue3): Fix the declared camelCase event cannot be recognized #2051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azurewarth0920
commented
Apr 13, 2023
| @@ -371,13 +371,14 @@ function processRefs (instance) { | |||
| function processEventListeners (instance) { | |||
| const emitsDefinition = instance.type.emits | |||
| const declaredEmits = Array.isArray(emitsDefinition) ? emitsDefinition : Object.keys(emitsDefinition ?? {}) | |||
| const normalizedDeclaredEmits = declaredEmits.map(key => kebabize(key)) | |||
| const keys = Object.keys(instance.vnode.props ?? {}) | |||
| const result = [] | |||
| for (const key of keys) { | |||
| const [prefix, ...eventNameParts] = key.split(/(?=[A-Z])/) | |||
| if (prefix === 'on') { | |||
| const eventName = eventNameParts.join('-').toLowerCase() | |||
There was a problem hiding this comment.
This line makes the eventName kebabized.
But the variable declaredEmits is a mixed case array, which will cause a mismatch.
Azurewarth0920
force-pushed
the
fix/event-case-unmatch
branch
from
0e9c28b
to
793b3d2
Compare
|
Sale issue, it is quite misleading to have warnings from Vue Devtools if we use camelCase instead of kebab-case for events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: #2046
fix: #2063
fix: #2060
Fix the declared camelCase event that cannot be recognized.
the declaredEmits are not normalized to kebab case, which results in the mismatching with the declared events on the parent component side.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).