Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skipLibCheck option in the TS template (defaults to true) #5688

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

haoqunjiang
Copy link
Member

References:

Pros:

  • Greatly speeds up TypeScript compilation (not a big issue in Vue CLI because we use fork-ts-checker-webpack-plugin)
  • Both TypeScript and Vue minor version updates, though as widely tested as they can go, still have chances to break existing type definitions. Users' projects should not break because of code they can't control.
  • As Vue 3 is still in the pre-release stage, the type definitions may still have breaking changes and ecosystem packages shall take some time to catch up. For average users, enabling skipLibCheck brings a better experience.

Cons:

/cc @cexbrayat

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FYI: to be accurate, the change was later reverted in Angular CLI (see angular/angular-cli@a42f580) because of the downside of not checking the local d.ts files. It is currently not enabled by default, but that doesn't change anything to your points 👍

@haoqunjiang haoqunjiang merged commit c98f76a into vuejs:dev Jul 16, 2020
@haoqunjiang haoqunjiang deleted the skipLibCheck branch July 16, 2020 07:27
peace-maker added a commit to spq/pkappa2 that referenced this pull request Aug 5, 2024
"Both TypeScript and Vue minor version updates, though as widely tested as they can go, still have chances to break existing type definitions. Users' projects should not break because of code they can't control."

vuejs/pinia#2605
vuejs/vue-cli#5688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants