-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adjust plugin dev guide example to write modified contents, fixes #3655 #3656
docs: adjust plugin dev guide example to write modified contents, fixes #3655 #3656
Conversation
@akrawchyk thank you so much for spotting this! I think I missed contentMain = lines.join('\n'); in my example but including end of line makes it even better. |
@NataliaTepluhina no prob 😄 , I can update the example to use either |
I think EOL is more consistent in this case so let's leave it your way 😉 @sodatea please have a final look 🙇♀️ |
The best option is to maintain the line-ending (like prettier prettier/prettier#472) (sidenote: Airbnb Style Guide enforces |
use `EOL` instead of `\n` Co-Authored-By: akrawchyk <[email protected]>
fixes #3655