Extract local path logic and add tests. #341
Conversation
|
Maybe we should use appveyor for vue-cli to run tests on a windows machine too |
Always pass call callback function on generate. Previously tests were randomly failing when running few times in a row.
npm windows issues
|
@posva I added appveyor which is finally passing now. I had configuration wrong and it was running against node 4 (which is fine) but there was npm v2 installed which wasn't fine. I also found we had some race conditions in tests, reading from same directory (thanks Windows) etc. Should be all fixed in this PR now. |
|
@zigomir 😆 I see that you had some trouble due to the commit history. I hope it wasn't too much of a pain |
lib/local-path.js
Outdated
|
|
||
| module.exports = { | ||
| isLocalPath: function (templatePath) { | ||
| return /^[./]|(^[a-z|A-Z]:)/.test(templatePath) |
There was a problem hiding this comment.
Why is the | inside of the [] necessary?
There was a problem hiding this comment.
Huh, might not be at all :) (regex by trial and error image here 😊)
- CR feedback
|
@posva hehe yeah. No worries, I think it's good that we run tests on Windows too. + I learned a bit how appveyor works. I changed regex as you pointed out in CR. Let me know if there is anything else we should change. Also, worth noting are weird race condition issues that were resolved here: 1f15a01 |
|
thank your work <3 |
Fixes #300 and #283.
Thanks @ajanes93 for opening a PR. Also thanks to @likun7981 for providing regex.
Only thing wrong in regex imho was assumption that windows drive letter can be of any length and thus
bitbucket:username/repwas treated as local template. I fixed this in this PR and also added some tests.I'm aware that running these tests on Windows won't pass because of
isAbsoluteused, but CircleCi runes on *nix so... I'm open to any suggestions.@egoist what do you think?