Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(theme-default): CSS to SCSS #850

Closed
wants to merge 1 commit into from
Closed

refactor(theme-default): CSS to SCSS #850

wants to merge 1 commit into from

Conversation

jd-solanki
Copy link
Contributor

This PR:

  • Refactors theme-default code from CSS to SCSS
  • Allows .vp-raw class to isolate vp-doc styles

@jd-solanki jd-solanki mentioned this pull request Jun 24, 2022
Closed
@kiaking
Copy link
Member

kiaking commented Jun 27, 2022

No, we're not using SCSS. I like the idea of adding .vp-raw but please refrain from adding SCSS. I would be OK to add postcss plugin for nesting syntax though.

@brc-dd brc-dd closed this Jun 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jd-solanki @kiaking @brc-dd