-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme): final re-brand #2727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated some stuff to improve perf 🚀
Thanks for the tweak! I don't know why but I converted png to webp and it got even smaller (33kb) so I've replaced it with that 🤔 And fixed some border color issue on CSS var. |
Great great great job! Look so cool !👀 |
Yeah, I too expected it to be smaller. But pixelmator generated that 50 kB or something. I think we can merge this. Looks nice to me! ✨ |
Shall we adjust the text color for the danger containers I found the following suggestions using chrome devtools, that are very close to the current color:
Right now we use the same color for both light and dark themes, but unfortunately there is no shade of red which meets the AA contrast requirement for both themes: First picture is for dark, second is for light theme. |
@kiaking close #2119 as well if the container colors are adjusted 🙌 PS: we can also pick base colors from https://www.radix-ui.com/colors, their grouping seem to yield 5-10 contrast ratio (use 9/10/11 for text, 1/2 for bg, toggle dark/light - they are overidden) |
Co-authored-by: Lehoczky Zoltán <[email protected]>
@brc-dd do we have some codeblock inside |
By playground, do you mean e2e tests? There aren't a11y checks there right now. We can add those, but currently they will fail. They shouldn't be necessary IMO, we won't later be changing the colors much. |
I mean, with a simple visual test via |
What's the playground? The deploy preview https://deploy-preview-2727--vitepress-docs.netlify.app/guide/markdown#custom-containers ? |
Added social preview image 👍 |
The final re-branding before going RC. The VitePress brand is now aligns with Vite.
I have tweak mostly the CSS vars but tiny other parts that I wonted adjust a bit. Now we have 2 separate colors for Light/Dark mode. We should be eliminate a11y problems we have or would have in the future.