Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): final re-brand #2727

Merged
merged 7 commits into from
Aug 8, 2023
Merged

feat(theme): final re-brand #2727

merged 7 commits into from
Aug 8, 2023

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Aug 3, 2023

The final re-branding before going RC. The VitePress brand is now aligns with Vite.

I have tweak mostly the CSS vars but tiny other parts that I wonted adjust a bit. Now we have 2 separate colors for Light/Dark mode. We should be eliminate a11y problems we have or would have in the future.

  • Add social preview images

Screenshot 2023-08-03 at 21 13 51 Screenshot 2023-08-03 at 21 14 05 Screenshot 2023-08-03 at 21 16 00 Screenshot 2023-08-03 at 21 15 40

@kiaking kiaking added enhancement New feature or request theme Related to the theme labels Aug 3, 2023
@kiaking kiaking requested a review from brc-dd August 3, 2023 12:28
@kiaking kiaking self-assigned this Aug 3, 2023
Copy link
Member

@brc-dd brc-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated some stuff to improve perf 🚀

@kiaking
Copy link
Member Author

kiaking commented Aug 4, 2023

Thanks for the tweak! I don't know why but I converted png to webp and it got even smaller (33kb) so I've replaced it with that 🤔 And fixed some border color issue on CSS var.

@zonemeen
Copy link
Collaborator

zonemeen commented Aug 4, 2023

Great great great job! Look so cool !👀

@brc-dd
Copy link
Member

brc-dd commented Aug 4, 2023

I don't know why but I converted png to webp and it got even smaller (33kb)

Yeah, I too expected it to be smaller. But pixelmator generated that 50 kB or something.

I think we can merge this. Looks nice to me! ✨

@Lehoczky
Copy link
Contributor

Lehoczky commented Aug 5, 2023

Shall we adjust the text color for the danger containers (--vp-custom-block-danger-text) to meet the AA contrast ratio?

I found the following suggestions using chrome devtools, that are very close to the current color:

  • for dark theme: #ff4666 instead of #f43f5e
  • for light theme: #cd354f instead of #f43f5e

Right now we use the same color for both light and dark themes, but unfortunately there is no shade of red which meets the AA contrast requirement for both themes:

image
image

First picture is for dark, second is for light theme.

@brc-dd
Copy link
Member

brc-dd commented Aug 5, 2023

@kiaking close #2119 as well if the container colors are adjusted 🙌

PS: we can also pick base colors from https://www.radix-ui.com/colors, their grouping seem to yield 5-10 contrast ratio (use 9/10/11 for text, 1/2 for bg, toggle dark/light - they are overidden)

@userquin
Copy link
Member

userquin commented Aug 6, 2023

@brc-dd do we have some codeblock inside ::: <tip|info|warning|error> in the playground? We should check color constrast, something like this https://vite-pwa-org.netlify.app/guide/auto-update.html#automatic-reload.

@brc-dd
Copy link
Member

brc-dd commented Aug 6, 2023

do we have some codeblock inside ::: <tip|info|warning|error> in the playground?

By playground, do you mean e2e tests? There aren't a11y checks there right now. We can add those, but currently they will fail. They shouldn't be necessary IMO, we won't later be changing the colors much.

@userquin
Copy link
Member

userquin commented Aug 6, 2023

I mean, with a simple visual test via dev tools, there is no need to add a11y tests

@brc-dd
Copy link
Member

brc-dd commented Aug 6, 2023

What's the playground? The deploy preview https://deploy-preview-2727--vitepress-docs.netlify.app/guide/markdown#custom-containers ?

@kiaking
Copy link
Member Author

kiaking commented Aug 8, 2023

Added social preview image 👍

@brc-dd brc-dd merged commit c0d838b into main Aug 8, 2023
@brc-dd brc-dd deleted the final-re-brand branch August 8, 2023 10:37
@jd-solanki jd-solanki mentioned this pull request Aug 8, 2023
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request theme Related to the theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No contrast of code on table row in light theme
5 participants