Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(a11y): add aria-label to language button #2025

Merged
merged 6 commits into from
Mar 8, 2023
Merged

perf(a11y): add aria-label to language button #2025

merged 6 commits into from
Mar 8, 2023

Conversation

sabicalija
Copy link
Contributor

close #2021

@sabicalija sabicalija changed the title fix(theme): set aria-label for language button switch in navigation fix(theme): set aria-label for change language button in navigation Mar 2, 2023
kiaking
kiaking reviewed Mar 3, 2023
View reviewed changes
docs/guide/i18n.md Outdated Show resolved Hide resolved
brc-dd
brc-dd reviewed Mar 3, 2023
View reviewed changes
types/shared.d.ts Outdated Show resolved Hide resolved
@sabicalija sabicalija force-pushed the fix-language-button-aria branch 2 times, most recently from 71b4414 to 2837f77 Compare March 3, 2023 08:23
@sabicalija
Copy link
Contributor Author

It would be nice, if the default configuration for the deploy/netlify deployment could include locales configuration to allow for testing features in that context.

@sabicalija sabicalija changed the title fix(theme): set aria-label for change language button in navigation fix(theme): add langMenuAriaLabel to set aria-label of language menu button in navigation Mar 4, 2023
@sabicalija
Copy link
Contributor Author

I've discovered related issues with the sidebar today. Probably it is relevant for other "group" and "dropdown" elements.

image
image

If you would merge fixes, I can prepare a PR or include fixes with this one. Pls just let me know. @kiaking @brc-dd

@sabicalija sabicalija requested review from kiaking and brc-dd and removed request for kiaking and brc-dd March 6, 2023 12:48
@sabicalija sabicalija force-pushed the fix-language-button-aria branch 3 times, most recently from 1c476a7 to 31b02ef Compare March 6, 2023 13:57
@sabicalija sabicalija force-pushed the fix-language-button-aria branch from 31b02ef to 85071e4 Compare March 6, 2023 14:22
@brc-dd brc-dd changed the title fix(theme): add langMenuAriaLabel to set aria-label of language menu button in navigation perf(a11y): add aria-label to language button Mar 8, 2023
@brc-dd brc-dd merged commit 322c633 into vuejs:main Mar 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brc-dd brc-dd brc-dd left review comments

@kiaking kiaking kiaking left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Switch Language' Button does not have an accessible name
3 participants
@sabicalija @kiaking @brc-dd