Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add linkage for code-groups in getting-started #1906

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

manchan4869
Copy link
Contributor

Set the selection of package manager in getting-started to be linked

It seems that only this page can be optimized in this way, so it is directly written in the<script>

@brc-dd brc-dd merged commit f1fe79b into vuejs:main Feb 11, 2023
@brc-dd
Copy link
Member

brc-dd commented Feb 11, 2023

Just FYI, if someone is coming to this later, one can also directly use https://vitepress-plugins.sapphi.red/tabs/#tabs-with-shared-selection-state

@brc-dd
Copy link
Member

brc-dd commented Feb 14, 2023

Gonna revert this, it actually breaks code groups on all the pages once you open index. Probably should have used onmounted and onunmounted here.

brc-dd added a commit that referenced this pull request Feb 14, 2023
brc-dd added a commit that referenced this pull request Feb 14, 2023
…1943)

Revert "docs: shared selection state in `code-groups` in `getting-started` (#1906)"

This reverts commit f1fe79b.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants