Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: VPNavBarMenuLink no external icon #1881

Merged
merged 1 commit into from
Feb 25, 2023
Merged

fix: VPNavBarMenuLink no external icon #1881

merged 1 commit into from
Feb 25, 2023

Conversation

meedfine
Copy link
Contributor

@meedfine meedfine commented Feb 2, 2023 •
edited
Loading

i found externalIcon only show in VPMenuLink, not show in VPNavBarMenuLink
why? so i remove the noIcon bind
image

image

image

image

@meedfine
Copy link
Contributor Author

meedfine commented Feb 2, 2023

@kiaking

@AlxisHenry AlxisHenry mentioned this pull request Feb 8, 2023
Open
@meedfine meedfine mentioned this pull request Feb 17, 2023
Closed
4 tasks
@MarkusKeck
Copy link
Collaborator

Also fixes #1948

@meedfine
Copy link
Contributor Author

@brc-dd

@brc-dd brc-dd merged commit 8e6e8d9 into vuejs:main Feb 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brc-dd brc-dd brc-dd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meedfine @MarkusKeck @brc-dd