Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code plugins styles #142

Merged
merged 2 commits into from
Nov 24, 2020
Merged

fix: code plugins styles #142

merged 2 commits into from
Nov 24, 2020

Conversation

patak-dev
Copy link
Member

Fixes font sizing and vertical padding styles for highlight lines and line numbers code plugins in the default theme

highlight-lines-style-issue

line-numbers-issue

I added two new vars: --code-font-size and --code-vertical-padding. The vertical padding is only modifying the plugin's styles after this PR because it requires a bit of refactoring to make the code padding dynamic and I am not sure what is the best way to do it.

After the fix:

code-after

@kiaking kiaking added the bug Something isn't working label Nov 24, 2020
@kiaking
Copy link
Member

kiaking commented Nov 24, 2020

Wonderful! Thanks a lot 🙌

@kiaking kiaking merged commit 0c644fc into vuejs:master Nov 24, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants