refactor: migrate default theme to use script-setup #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Niiice! Watch out for the conflicts since I'm planning to adjust more on themes 🔥 I think import type issue is not because of <script setup>, I remember I had the same issue before so I thought it was a limitation for Vite 🤔 I agree it wouldn't be a deal breaker though. |
|
This is now ready. I would recommend enabling Volar instead of Vetur for now while working on this codebase. |
|
@yyx990803 Niiice! Let me do the final checks on various example and merge this one 👍 I'll fix the conflicts if we get any. |
posva
reviewed
Nov 26, 2020
1 task
|
Suddenly, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR containing my local changes migrating the default them to use
<script setup>as proposed in vuejs/rfcs#227.Specifically I verified that the inline compile mode works as intended. One quirk discovered is that when using
<script setup lang="ts">it is necessary to explicitly mark type imports withimport type { X } from '...'otherwise it will be used as a value in the setup return statement. It should be technically possible to avoid this limitation with more sophisticated analysis but for now I don't think it's a deal breaker.Note this PR isn't "working" yet and is here demonstrating the code simplifications that can be provided by the new RFC. Shipping it depends on the following:
@vue/compiler-sfcfor the new syntax AND inline compile modeviteandrollup-plugin-vuewith compatibility updates<script setup>syntax. In a few cases the binding analysis fails on destructuring declarations (<script setup>variables declared with destructure language-tools#24)