Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add vitepress docs #126

Merged
merged 5 commits into from
Nov 19, 2020
Merged

docs: add vitepress docs #126

merged 5 commits into from
Nov 19, 2020

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Nov 16, 2020

This PR adds the docs for VitePress. It's not complete, but I wanted to start creating it since we get lots of questions, but don't have good place to put all those answers.

Also, this is really nice place to play around with VitePress features as well.

@kiaking kiaking self-assigned this Nov 16, 2020
"build": "vitepress build src"
},
"devDependencies": {
"vitepress": "^0.7.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use the code in the repo itself to deploy the docs? I think that also serves as a form of e2e test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes I think we should! Just wasn't sure how...? I was looking into VuePress code and seems like it was doing this way... so...

Do you have any idea how we can do this 🤔 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yyx990803 OK I think I fixed it. Not sure if this is the cleanest way to go. So now we have docs/package.json that only contains scripts. This is because if we reference bin/vitepress.js from root package.json, it tries to optimize node specific modules and crashes.

While we don't have a way to pass optimizeDev option to underlining Vite, I went this way.

kiaking and others added 2 commits November 17, 2020 15:29
@yyx990803 yyx990803 merged commit bab1391 into master Nov 19, 2020
@kiaking kiaking deleted the vitepress-docs branch November 20, 2020 04:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants