Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to extends social links #738

Closed
4 tasks done
stafyniaksacha opened this issue Jun 7, 2022 · 4 comments · Fixed by #953
Closed
4 tasks done

Add option to extends social links #738

stafyniaksacha opened this issue Jun 7, 2022 · 4 comments · Fixed by #953
Labels
enhancement New feature or request theme Related to the theme

Comments

@stafyniaksacha
Copy link
Contributor

stafyniaksacha commented Jun 7, 2022

Is your feature request related to a problem? Please describe.

Social networks available are hard coded, so we can not include new one (such as dribble, gitlab, envato, ...)

type SocialLinkIcon =
    | 'discord'
    | 'facebook'
    | 'github'
    | 'instagram'
    | 'linkedin'
    | 'slack'
    | 'twitter'
    | 'youtube'

Describe the solution you'd like

That would be great if we can add link with icons from https://icones.js.org/ or from custom component

Describe alternatives you've considered

No response

Additional context

No response

Validations

@brc-dd brc-dd added enhancement New feature or request theme Related to the theme labels Jun 7, 2022
@brc-dd
Copy link
Member

brc-dd commented Jun 7, 2022

We are actually thinking of modifying the interface to allow inline SVGs. Then you'll be able to use any icon you wish.

@userquin
Copy link
Member

userquin commented Jun 9, 2022

Use UnoCSS preset icons, adding the vite plugin, the preset and also @iconify/logos (all svg to css)

@kiaking kiaking changed the title [next] extends social links Add option to extends social links Jun 14, 2022
@kiaking
Copy link
Member

kiaking commented Jun 14, 2022

I think having able to define inline svg is enough for this feature. Becasue you usually don't have that much of Social icons anyway. having decent default is cool, so I think adding GitLab makes sense for example, but other than that, I think user could just copy paste svg into config.

I really wouldn't want to complicate the system by including another package into build pipeline 👀

@stafyniaksacha
Copy link
Contributor Author

I think user could just copy paste svg into config.

Sounds good for me

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request theme Related to the theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants