-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next] support external for editlink #694
Comments
Except for leading |
Yes, except for the leading the URL is fine. |
I was also surprised that this functionality has degraded. I will be looking forward to the changes |
@brc-dd @kecrily This is kinda getting complicated 😅 Before we were using this info to display GitHub social link logo on Nav bar as well, so it made sense to have these small options. But now, this option is really only used for this edit link. So, how about we make config simpler? editLink: {
path: 'https://github.com/vuejs/vitepress/edit/next/docs/{:path}',
text: '在 GitLab 上编辑此页',
} The What do you think? |
@kiaking Seems right. In pattern we are simply replacing |
If we won't be reusing these options elsewhere, then let's drop the baggage and simply get on with it. |
close #694 close #697 Co-authored-by: Kia Ishii <[email protected]>
Is your feature request related to a problem? Please describe.
My project is hosted on GitLab, so I configured editLink as below:
but the editlink turned out to be
https://github.com/https://gitlab.com/foo/bar/docs/edit/main/docs/application/management.md
Describe the solution you'd like
I noticed before
v1.0.0
, we have aisExternal
function to tell if usegithub.com
orrepo
config directly as base url.Describe alternatives you've considered
No response
Additional context
No response
Validations
The text was updated successfully, but these errors were encountered: