Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize target and rel attributes for home layout #3472

Closed
4 tasks done
wodeni opened this issue Jan 18, 2024 · 1 comment · Fixed by #3528
Closed
4 tasks done

Customize target and rel attributes for home layout #3472

wodeni opened this issue Jan 18, 2024 · 1 comment · Fixed by #3528
Labels
contribution welcome The team would welcome a contribution from the community for this issue enhancement New feature or request theme Related to the theme

Comments

@wodeni
Copy link

wodeni commented Jan 18, 2024

Is your feature request related to a problem? Please describe.

Now that pathname protocol has been removed (5836fac), the home layout cannot emulate the behavior by specifying target and rel attributes of actions. In my case, I had been using pathname to link to an SPA hosted together with the main site, and was able to use target: "_blank" for the nav bar, but not the home page action (PR: penrose/penrose#1704).

Describe the solution you'd like

Just like the nav bar in config.ts, the actions of home layout exposes target and rel.

Describe alternatives you've considered

  • Not using the default theme home layout but I'd love to keep using the default theme!
  • Bring back pathname, which is unlikely
  • Turn off cleanUrl, but this will impact the entire site, which is not desirable.

Additional context

Related issue on sidebar links: #2851

Validations

@brc-dd brc-dd added enhancement New feature or request theme Related to the theme contribution welcome The team would welcome a contribution from the community for this issue labels Jan 19, 2024
@liana-p
Copy link
Contributor

liana-p commented Jan 31, 2024

Implementing this, will open a PR for it soon

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution welcome The team would welcome a contribution from the community for this issue enhancement New feature or request theme Related to the theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants