-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base
option not generating correct multi sidebar
#231
Comments
It also appears that |
Confirmed. Sidebar not correctly showing with multi sidebar. Must be forgetting to take in @TheDutchCoder I can't confirm |
base
PR breaks sidebarsbase
option not generating correct sidebar
@kiaking same result as specifying the sidebar manually, it's hidden in the CSS (and missing all children). |
base
option not generating correct sidebarbase
option not generating correct multi sidebar
@TheDutchCoder I made a fix at #234. This should fix multi sidebar issue, but not sure about |
Let me quickly check! |
@kiaking in 0.12.0 I still have that issue yes, Let me add some screenshots, maybe it helps |
Oh OK that's expected. You don't have heading to show on the sidebar. Try adding Level 2 headers to the markdown. Not sure if we should completely hide Sidebar when there're no headings in the markdown though 🤔 But that's some other issues to be discussed 👍 |
Everything works fine for me with |
Describe the bug
Yesterday's PR (#223) introduced the ability to have a base option work with dev mode. However this change breaks sidebar implementations and they no longer show up.
This happens in both dev and prod builds.
To Reproduce
The following config works without the base option set, but not with it:
Expected behavior
The sidebars to appear (I think it might not resolve the files correctly anymore)
System Info
The text was updated successfully, but these errors were encountered: