fix(theme): bind missing no icon prop in the menu link component (#4260)

Co-authored-by: Divyansh Singh <[email protected]>
vuejs · Oct 12, 2024 · d4712c1 · d4712c1
1 parent 39236c5
commit d4712c1
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/client/theme-default/components/VPMenuLink.vue b/src/client/theme-default/components/VPMenuLink.vue
@@ -18,9 +18,9 @@ const { page } = useData()
       :href="item.link"
       :target="item.target"
       :rel="item.rel"
-    >
-      {{ item.text }}
-    </VPLink>
+      :no-icon="item.noIcon"
+      v-html="item.text"
+    />
   </div>
 </template>
 

diff --git a/src/client/theme-default/components/VPNavBarMenuLink.vue b/src/client/theme-default/components/VPNavBarMenuLink.vue
@@ -22,13 +22,12 @@ const { page } = useData()
       )
     }"
     :href="item.link"
-    :noIcon="item.noIcon"
     :target="item.target"
     :rel="item.rel"
+    :no-icon="item.noIcon"
     tabindex="0"
-  >
-    <span v-html="item.text"></span>
-  </VPLink>
+    v-html="item.text"
+  />
 </template>
 
 <style scoped>

diff --git a/src/client/theme-default/components/VPNavScreenMenuGroupLink.vue b/src/client/theme-default/components/VPNavScreenMenuGroupLink.vue
@@ -16,10 +16,10 @@ const closeScreen = inject('close-screen') as () => void
     :href="item.link"
     :target="item.target"
     :rel="item.rel"
+    :no-icon="item.noIcon"
     @click="closeScreen"
-  >
-    {{ item.text }}
-  </VPLink>
+    v-html="item.text"
+  />
 </template>
 
 <style scoped>

diff --git a/src/client/theme-default/components/VPNavScreenMenuLink.vue b/src/client/theme-default/components/VPNavScreenMenuLink.vue
@@ -16,6 +16,7 @@ const closeScreen = inject('close-screen') as () => void
     :href="item.link"
     :target="item.target"
     :rel="item.rel"
+    :no-icon="item.noIcon"
     @click="closeScreen"
     v-html="item.text"
   />