fix(theme): show outline even without sidebar (#1189)

vuejs · Aug 17, 2022 · 3714ea3 · 3714ea3
1 parent a8834ac
commit 3714ea3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 15 deletions.
diff --git a/examples/minimal/__test__/content.spec.ts b/examples/minimal/__test__/content.spec.ts
@@ -7,9 +7,9 @@ describe('render corrent content', () => {
   })
 
   test('main content', async () => {
-    const h1Locator = await page.locator('h1')
-    const h2Locator = await page.locator('h2')
-    const pLocator = await page.locator('.Layout p')
+    const h1Locator = page.locator('h1')
+    const h2Locator = page.locator('h2')
+    const pLocator = page.locator('.Layout p')
 
     const [h1Contents, h2Conetents, pContents] = await Promise.all([
       h1Locator.allTextContents(),
@@ -28,11 +28,11 @@ describe('render corrent content', () => {
   })
 
   test('outline', async () => {
-    const outlineLinksLocator = await page.locator(
+    const outlineLinksLocator = page.locator(
       '.VPDocAsideOutline .root .outline-link'
     )
 
     const outlineLinksCount = await outlineLinksLocator.count()
-    expect(outlineLinksCount).toEqual(0)
+    expect(outlineLinksCount).toEqual(4)
   })
 })
diff --git a/src/client/theme-default/components/VPDoc.vue b/src/client/theme-default/components/VPDoc.vue
@@ -73,10 +73,6 @@ const pageName = computed(() =>
     max-width: 992px;
   }
 
-  .VPDoc:not(.has-sidebar) .aside {
-    display: block;
-  }
-
   .VPDoc:not(.has-sidebar) .content {
     max-width: 752px;
   }

diff --git a/src/client/theme-default/composables/sidebar.ts b/src/client/theme-default/composables/sidebar.ts
@@ -23,13 +23,9 @@ export function useSidebar() {
   })
 
   const hasAside = computed(() => {
-    if (
-      frontmatter.value.layout !== 'home' &&
-      frontmatter.value.aside === false
+    return (
+      frontmatter.value.layout !== 'home' && frontmatter.value.aside !== false
     )
-      return false
-
-    return hasSidebar.value
   })
 
   function open() {