Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search shortcut for Windows is broken #35

Closed
kiaking opened this issue Nov 24, 2021 · 4 comments
Closed

Search shortcut for Windows is broken #35

kiaking opened this issue Nov 24, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@kiaking
Copy link
Member

kiaking commented Nov 24, 2021

Need to fix this one. The CTRL icon(?) is not looking fantastic.

Screen Shot 2021-11-24 at 22 04 36

@kiaking kiaking added the bug Something isn't working label Nov 24, 2021
@Jinjiang
Copy link
Member

Jinjiang commented Aug 2, 2022

image

Seems it's normal now and the shortcut works on my Windows laptop.

@kiaking would you mind a double-check? :-)

Update: I found when you activate the search bar once, the "ctrl" will be changed from a text (my screenshot) into a SVG icon (@kiaking 's screenshot), which looks a little bit smaller. Same to the "meta" on macOS. I feel it's a feature, not a bug.

@brc-dd
Copy link
Member

brc-dd commented Aug 23, 2022

Might wanna backport this: vuejs/vitepress#986

@Jinjiang
Copy link
Member

Jinjiang commented Aug 27, 2022

I found another difference is @vue/theme uses <span>s rather than <kbd>s to render the keys. As a result, it shows different styles before and after the actual search box is loaded.

PR created. #71

@yyx990803
Copy link
Member

Closing as it seems to have been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants