Bump Vue to 3.0.4 #285
Closed
Bump Vue to 3.0.4 #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, I gave vuejs/core#2750 a go and it fixes our issue as well. Shall we wait for 3.0.5, then? |
|
Oh, great! Let's wait for 3.0.5. I lost quite a few hours debugging this one too. Glad someone has found the bug. |
|
Looks like the PR didn't make it to 3.0.5, we'll need to wait a bit longer 😉 |
|
Closing this one as we are now up-to-date with vue-next 3.0.6 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #278.
Nothing to see here, yet – I'm on it, but I wanted to open a draft PR in case anyone was working on it, too.
So far, this is what I could track down from vue-next:
rawChildren is null here: https://github.com/vuejs/vue-next/blob/3bc2914e32b030b1247659f871f6055827154087/packages/runtime-core/src/componentRenderUtils.ts#L230
This appears to be the offending commit, putting back highlighted lines makes test pass again: vuejs/core@3bc2914#diff-3f88622d34d4d3a0b6e44ddd42967279cc0d25f817d6f17fad79ae4b205c405eL225-L227