feat(types): infer options in plugins #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cexbrayat
approved these changes
Dec 22, 2020
| config.plugins.VueWrapper.install(PluginWithOptionalOptions2, { msg: 'hello' }) | ||
|
|
||
| // FIXME: not sure if this one is possible | ||
| // expectError(config.plugins.VueWrapper.install(PluginWithoutOptions, {})) |
There was a problem hiding this comment.
I guess this is fine?
The FIXME needs to be removed before merging.
There was a problem hiding this comment.
I think it's fine too but I thought I might have overlooked a way of doing it in TS. If there is nothing to fix, yeah, better remove it 😆
There was a problem hiding this comment.
We could probably do something, but I'm not sure it's worth the time, the hassle and the maintenance cost 😉 Thanks for the PR!
posva
commented
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #269