-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer attrs for implementing HOCs #477
Open
rudyxu1102
wants to merge
12
commits into
vuejs:master
Choose a base branch
from
rudyxu1102:feat/infer_attrs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudyxu1102
force-pushed
the
feat/infer_attrs
branch
from
January 1, 2023 11:01
8337aa3
to
d2c1751
Compare
rudyxu1102
force-pushed
the
feat/infer_attrs
branch
from
January 2, 2023 03:23
0169cde
to
824ea5d
Compare
rudyxu1102
force-pushed
the
feat/infer_attrs
branch
from
January 3, 2023 15:35
b6be25d
to
a71a63f
Compare
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allowing to infer attrs by using
attrs
option ofdefineComponent
ordefineCustomElement
.And in the
setup-script
, passing generic type in thedefineAttrs<T>
will also inferattrs
toT
.defineComponent
Setup Script
Links
Important: Do NOT comment on this PR. Please use the discussion thread linked above to provide feedback, as it provides branched discussions that are easier to follow.This also makes the edit history of the PR clearer.