-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for tsx #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transform from Sucrase is the implementation of React, so it doesn't work.
I think we should have #61 first, and then users can transform Vue JSX themselves. |
@sxzz sorry i didn't consider React situation, you may remove the transform config below, it's for vue only.
d0829ca#diff-adb065f7ea26f7f005649ad48bcbf0534bc860c701bb4e19c3917b125f4e2f20R22 |
No, I mean we cannot use the built-in JSX transform function from Babel. Instead, we should use the Babel plugin https://github.com/vuejs/babel-plugin-jsx if we have to support JSX. For example: <input v-model={foo}/> |
Thanks for mentioning this. just switched to Babel ! |
hi, when to merge? |
44d62e0
to
a445c93
Compare
hi, when to merge? |
1 similar comment
hi, when to merge? |
@sxzz @CaiWenlie is something still stopping this from being merged? |
bf18e08
to
df1a0fc
Compare
hi, when to merge? |
No description provided.