fix(types): Don't double UnwrapRef in setup stores

[bgoscinski]

fixes #2770

Without this change for setup stores UnwrapRef is applied to state type twice.

First time after defineStore infers the SS type parameter and passes it to _ExtractStateFromSetupStore:

pinia/packages/pinia/src/types.ts

Line 586 in 3c8782e

? _UnwrapAll<Pick<SS, _ExtractStateFromSetupStore_Keys<SS>>>

Then the result of _ExtractStateFromSetupStore<SS> is passed to StoreDefinition interface, which passes it to Store type, which does

pinia/packages/pinia/src/types.ts

Line 470 in 3c8782e

UnwrapRef<S> &

First unwrap call reduces state type

// from
{ foo: ShallowRef<{ bar: Ref<string> }> }
// to 
{ foo: { bar: Ref<string> } }

Second unwrap call reduces it further producing type that doesn't match the runtime value

// from
{ foo: { bar: Ref<string> } }
// to the incorrect
{ foo: { bar: string } }

[netlify]

✅ Deploy Preview for pinia-official canceled.

Name	Link
🔨 Latest commit	5519b8e
🔍 Latest deploy log	https://app.netlify.com/sites/pinia-official/deploys/66e21140e3257c000852dce9

[netlify]

✅ Deploy Preview for pinia-playground ready!

Name	Link
🔨 Latest commit	5519b8e
🔍 Latest deploy log	https://app.netlify.com/sites/pinia-playground/deploys/66e21140309cde00085fd641
😎 Deploy Preview	https://deploy-preview-2771--pinia-playground.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[bgoscinski]

This was passing even without my change because types are correctly set when using option stores

[bgoscinski]

my change causes that these 2 assertions pass as well

[bgoscinski]

@posva this is ready for review :)

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/@pinia/nuxt@2771

pnpm add https://pkg.pr.new/pinia@2771

pnpm add https://pkg.pr.new/@pinia/testing@2771

commit: 5519b8e

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.50%. Comparing base (3c8782e) to head (5519b8e).
Report is 2 commits behind head on v2.

Additional details and impacted files

@@            Coverage Diff             @@
##               v2    #2771      +/-   ##
==========================================
- Coverage   92.73%   92.50%   -0.23%     
==========================================
  Files          14       14              
  Lines        1335     1335              
  Branches      233      221      -12     
==========================================
- Hits         1238     1235       -3     
- Misses         97      100       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[posva]

Thanks!

[yyx990803]

FYI this breaks in ecosystem-ci with latest Vue: https://github.com/vuejs/ecosystem-ci/actions/runs/11050587708/job/30698660187

[posva]

I see it when upgrading to latest vue. It seems to be related to the new syntax with getter and setter on Refs. I will have to check deeper and probably avoid the custom setter part for stores